![]() | |
![]() |
| | Thread Tools | Display Modes |
#1
| |||
| |||
|
#2
| |||
| |||
|
|
I've just finished the layout and markup of http://www.fietsennaarlourdes.be/index Please give me your thoughts, ideas and critique about this website. |
#3
| |||
| |||
|
|
http://www.fietsennaarlourdes.be/index |

#4
| |||
| |||
|
|
I've just finished the layout and markup of http://www.fietsennaarlourdes.be/index Please give me your thoughts, ideas and critique about this website. |
#5
| |||
| |||
|
|
Samuel van Laere wrote: http://www.fietsennaarlourdes.be/index In your stylesheet: * { border: 0 none; font-family: inherit; font-size: 100%; font-style: inherit; font-weight: inherit; margin: 0; outline: 0; <-- very bad for accessibility! padding: 0; vertical-align: baseline; } This is a poor practice, even though it seems to be favored by dee-ziners. It means having to explicitly set margin and/or padding on every element, which only bloats the CSS with unnecessary junk. |
#6
| |||
| |||
|
|
On 2009-05-06, Bergamot wrote: Samuel van Laere wrote: http://www.fietsennaarlourdes.be/index In your stylesheet: * { margin: 0; padding: 0; } This is a poor practice, even though it seems to be favored by dee-ziners. It means having to explicitly set margin and/or padding on every element, which only bloats the CSS with unnecessary junk. Sometimes it's just the opposite: setting "margin: 0; padding: 0;" leads to a leaner stylesheet. If they are not there, I sometimes find myself having to constantly change inappropriate defaults. |
#7
| |||
| |||
|
|
Chris F.A. Johnson wrote: On 2009-05-06, Bergamot wrote: Samuel van Laere wrote: http://www.fietsennaarlourdes.be/index In your stylesheet: * { margin: 0; padding: 0; } This is a poor practice, even though it seems to be favored by dee-ziners. It means having to explicitly set margin and/or padding on every element, which only bloats the CSS with unnecessary junk. Sometimes it's just the opposite: setting "margin: 0; padding: 0;" leads to a leaner stylesheet. If they are not there, I sometimes find myself having to constantly change inappropriate defaults. Like what, for example? |
#8
| |||
| |||
|
|
On 2009-05-07, Bergamot wrote: Chris F.A. Johnson wrote: On 2009-05-06, Bergamot wrote: Samuel van Laere wrote: http://www.fietsennaarlourdes.be/index In your stylesheet: * { margin: 0; padding: 0; } This is a poor practice, even though it seems to be favored by dee-ziners. It means having to explicitly set margin and/or padding on every element, which only bloats the CSS with unnecessary junk. Sometimes it's just the opposite: setting "margin: 0; padding: 0;" leads to a leaner stylesheet. If they are not there, I sometimes find myself having to constantly change inappropriate defaults. Like what, for example? Any element that has a default margin or padding, e.g., <p>, <h1>. h2>, etc.... |
#9
| |||
| |||
|
|
I've just finished the layout and markup of http://www.fietsennaarlourdes.be/index Please give me your thoughts, ideas and critique about this website. Cheers, Samuel |
#10
| |||
| |||
|
|
Chris F.A. Johnson wrote: On 2009-05-07, Bergamot wrote: Chris F.A. Johnson wrote: On 2009-05-06, Bergamot wrote: Samuel van Laere wrote: http://www.fietsennaarlourdes.be/index In your stylesheet: * { margin: 0; padding: 0; } This is a poor practice, even though it seems to be favored by dee-ziners. It means having to explicitly set margin and/or padding on every element, which only bloats the CSS with unnecessary junk. |
|
Sometimes it's just the opposite: setting "margin: 0; padding: 0;" leads to a leaner stylesheet. If they are not there, I sometimes find myself having to constantly change inappropriate defaults. Like what, for example? Any element that has a default margin or padding, e.g., <p>, <h1>. h2>, etc.... So, you set everything to margin:0; padding:0; then leave it that way? Sounds like an unreadable blob of text to me. However, if you then go and set new margin/padding values on all these elements, then I see no advantage to setting them to 0 up front. ... |
![]() |
| Thread Tools | |
| Display Modes | |
| |