Gallery feedback

http://www.technologycommunity.com/s...lery/index.php


--
--
http://www.technologycommunity.com/

Matti Kiviharju wrote:

[snip link]

Is that spam, or are you asking for a critique?

--
Ben M.

Ben Measures wrote:

Matti Kiviharju wrote:

[snip link]


Is that spam, or are you asking for a critique?

I ask feedback, I don't sell here nothing.

--
--
http://www.technologycommunity.com/

Ben Measures wrote:

Matti Kiviharju wrote:

[snip link]


Is that spam, or are you asking for a critique?

Sorry, I got that the subject tells everyting.

--
--
http://www.technologycommunity.com/

Matti Kiviharju wrote:

Sorry, I got that the subject tells everyting.

The interesting thing is that whilst the subject line tells everything,
you shouldn't tell everything in the subject line. Say what you want in
the body and summarise in the subject.

First, coding issues (since we /are/ at alt.html.critique after all).

Your page has some errors that are caught by validator.w3.org . Tbh, you
should visit the validator every time you make changes to the markup
(and before you ask for a critique). This reveals 114 errors, mostly to
do with: & entities, "-marks left hanging in elements, presentational
attributes, and missing ALT attributes on images.

You have the HTML 4.01 Transitional doctype but use XML/XHTML-style
closing of empty elements - I suggest you either use XHTML completely
(ie. migrate to that doctype) or not at all.

You use table-layout, which has significant drawbacks. This has been
disscussed many times before, so please google for "why tables are bad".

I noticed your coding style is very presentational (ie. doesn't seperate
content from presentation), and you don't use CSS. I suggest you take
a quick dip and try to learn - it's well worth the effort. A good place
to start is http://www.w3schools.com/css .

Having said all that, I now suspect you didn't do any coding and left it
all to phpBB, your effort put into "skinning" instead. So I'll stop
here. If you want a critique on the design, I suggest you try
alt.design.graphics - though I warn that they can be just as scathing
with design as alt.html.critique can be over coding issues (especially
if your design is so-called "template"-based).

Hth,
--
Ben M.

Ben Measures wrote:

You have the HTML 4.01 Transitional doctype but use XML/XHTML-style
closing of empty elements - I suggest you either use XHTML completely
(ie. migrate to that doctype) or not at all.

There is errors because, orginal theme distribution contains errors.

I noticed your coding style is very presentational (ie. doesn't seperate
content from presentation), and you don't use CSS. I suggest you take a
quick dip and try to learn - it's well worth the effort. A good place to
start is http://www.w3schools.com/css .

I must to learn to use CSS.

Beter album here, that does not iclude HTML errors.
http://www.technologycommunity.com/s...pBB2/album.php


--
--
http://www.technologycommunity.com/