Custom Validations Altering Variable

I would like to know if it is possible to alter a variable during the
process of a custom validation. I know that it is no longer validation
when your altering data but in my opinion there are times when you
need alter it for simplicity sakes. A good example would be for a
world wide auction house type application and to to convert currency
to one single format, when you validate you check to see if both the
amount is alright along with the currency type. (This is assuming you
can type in what type of currency it is, and for this example is
possible.)

The application I am developing allows the user to type in multiple
currencies at one (This is a D20 RPG, and people type in something
along the line of 12 pp 145 gp 78 sp 21 cp) and so far the validation
process involves converting it all to the lowest currency type. But
for the sake of being DRY I would only need to add another line to set
the variable, but instead it is looking like I would have to repeat
the whole method and add in the single line and change it that way on
creation and updates.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

7H3LaughingMan wrote:

I would like to know if it is possible to alter a variable during the
process of a custom validation. I know that it is no longer validation
when your altering data but in my opinion there are times when you
need alter it for simplicity sakes.

That's not what validations are for. You want custom setter methods.

A good example would be for a
world wide auction house type application and to to convert currency
to one single format, when you validate you check to see if both the
amount is alright along with the currency type. (This is assuming you
can type in what type of currency it is, and for this example is
possible.)

With real-world currencies, it is my understanding that this is a bad
idea.

The application I am developing allows the user to type in multiple
currencies at one (This is a D20 RPG, and people type in something
along the line of 12 pp 145 gp 78 sp 21 cp) and so far the validation
process involves converting it all to the lowest currency type.

Again, don't do this in the validator. What you want is something like
this:

CONVERSIONS = {:sp => 10, :gp => 100, p => 1000}

def balance=(string)
# parse the string somehow to get the various amounts, then:

bal = cp
bal += gp * CONVERSIONS[:gp]
# likewise for other currencies

self[:balance] = bal
end

There's room for refactoring here, but you get the idea.

Best,
--
Marnen Laibow-Koser
http://www.marnen.org
marnen (AT) marnen (DOT) org
But

for the sake of being DRY I would only need to add another line to set
the variable, but instead it is looking like I would have to repeat
the whole method and add in the single line and change it that way on
creation and updates.

--
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

I would put this in a callback in the controller. I suggest starting
at before_save and go from there.

-eric

On Nov 7, 8:05*am, 7H3LaughingMan <austin.brk... (AT) gmail (DOT) com> wrote:

I would like to know if it is possible to alter a variable during the
process of a custom validation. I know that it is no longer validation
when your altering data but in my opinion there are times when you
need alter it for simplicity sakes. A good example would be for a
world wide auction house type application and to to convert currency
to one single format, when you validate you check to see if both the
amount is alright along with the currency type. (This is assuming you
can type in what type of currency it is, and for this example is
possible.)

The application I am developing allows the user to type in multiple
currencies at one (This is a D20 RPG, and people type in something
along the line of 12 pp 145 gp 78 sp 21 cp) and so far the validation
process involves converting it all to the lowest currency type. But
for the sake of being DRY I would only need to add another line to set
the variable, but instead it is looking like I would have to repeat
the whole method and add in the single line and change it that way on
creation and updates.
--~--~---------~--~----~------------~-------~--~----~

You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Eric wrote:

I would put this in a callback in the controller. I suggest starting
at before_save and go from there.

That would work, but I think it's conceptually wrong for what the OP
wants.

-eric

Best,
--
Marnen Laibow-Koser
http://www.marnen.org
marnen (AT) marnen (DOT) org
--
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

I don't agree.

Best,
Eric

On Nov 7, 10:22*am, Marnen Laibow-Koser <rails-mailing-l...@andreas-
s.net> wrote:

Eric wrote:
I would put this in a callback in the controller. I suggest starting
at before_save and go from there.

That would work, but I think it's conceptually wrong for what the OP
wants.

-eric

Best,
--
Marnen Laibow-Koserhttp://www.marnen.org
mar... (AT) marnen (DOT) org
--
Posted viahttp://www.ruby-forum.com/.
--~--~---------~--~----~------------~-------~--~----~

You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Alright I have set it all up and it will convert it to the lowest form
(and back for debugging purposes), however whenever I try to edit and
save using @armor.update_attributes(params[:armor]) it fails for some
reason. Here is a link to show you what I did with the model...

http://pastebin.com/me807521
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

7H3LaughingMan wrote:

Alright I have set it all up and it will convert it to the lowest form
(and back for debugging purposes), however whenever I try to edit and
save using @armor.update_attributes(params[:armor]) it fails for some
reason.

Fails in what way?

Here is a link to show you what I did with the model...

http://pastebin.com/me807521

I'll check it out in detail later on. On cursory inspection, however,
it looks like it has a lot of problems; I'll make some suggestions when
I'm not trying to type on my iPhone.

Perhaps Eric's before_save suggestion is the right idea after all.
Best,
--
Marnen Laibow-Koser
http://www.marnen.org
marnen (AT) marnen (DOT) org

--
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

I don't know how it fails but for some reason it refuses to update
when I edit it, I have it setup to where it goes back to the index
when you successfully edit something and when it doesn't work it goes
back to the edit page. It doesn't even throw any error messages.

On Nov 7, 3:30*pm, Marnen Laibow-Koser <rails-mailing-l...@andreas-
s.net> wrote:

7H3LaughingMan wrote:
Alright I have set it all up and it will convert it to the lowest form
(and back for debugging purposes), however whenever I try to edit and
save using @armor.update_attributes(params[:armor]) it fails for some
reason.

Fails in what way?

Here is a link to show you what I did with the model...

http://pastebin.com/me807521

I'll check it out in detail later on. *On cursory inspection, however,
it looks like it has a lot of problems; I'll make some suggestions when
I'm not trying to type on my iPhone.

Perhaps Eric's before_save suggestion is the right idea after all.
Best,
--
Marnen Laibow-Koserhttp://www.marnen.org
mar... (AT) marnen (DOT) org

--
Posted viahttp://www.ruby-forum.com/.
--~--~---------~--~----~------------~-------~--~----~

You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

7H3LaughingMan wrote:

I don't know how it fails but for some reason it refuses to update
when I edit it, I have it setup to where it goes back to the index
when you successfully edit something and when it doesn't work it goes
back to the edit page. It doesn't even throw any error messages.

I'll pay special attention to that, then. Are your tests passing?

On Nov 7, 3:30�pm, Marnen Laibow-Koser <rails-mailing-l...@andreas-

Best,
--
Marnen Laibow-Koser
http://www.marnen.org
marnen (AT) marnen (DOT) org
--
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Haven't really created any "proper" tests since I actually only have
one controller at the moment and I can test it via browser. All of my
methods work however whenever I do an update it doesn't touch the set
method to change the variable. (Tested with simple outputing text to
say that it was being used)

On Nov 7, 8:59*pm, Marnen Laibow-Koser <rails-mailing-l...@andreas-
s.net> wrote:

7H3LaughingMan wrote:
I don't know how it fails but for some reason it refuses to update
when I edit it, I have it setup to where it goes back to the index
when you successfully edit something and when it doesn't work it goes
back to the edit page. It doesn't even throw any error messages.

I'll pay special attention to that, then. *Are your tests passing?



On Nov 7, 3:30 pm, Marnen Laibow-Koser <rails-mailing-l...@andreas-

Best,
--
Marnen Laibow-Koserhttp://www.marnen.org
mar... (AT) marnen (DOT) org
--
Posted viahttp://www.ruby-forum.com/.
--~--~---------~--~----~------------~-------~--~----~

You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonrails-talk (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe (AT) googlegroups (DOT) com
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---