Javascript question ( kind of long )

I've got this script that's supposed randomly pic banner ads to
display. It works fine as shown at the bottom.

The problem is when I try to change the line:
document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG
SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

to

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'
target="_blank"><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

I want to set the target to "_blank", so if the user clicks on the ad
it opens in a new window. But when I do this, it ends up not doing
anything at all! Any suggestions? The complete script is located
below.



(in the head section)

<SCRIPT language="JavaScript">
<!--
/* You can get this script and many others
by visiting JavaScript City at: http://www.javascriptcity.com . */

pic_width=468; /*change to match the height of all your images */
pic_height=60; /* change to match the width of all your images */
border_size=0; /* change to the border size you want on the images
*/
alignment=1; /* 0=left,1=center */

/* define image urls */

if (document.images)
{
pic1= new Image(pic_width,pic_height);
pic1.src="http://someplace.com/banner1.gif";
pic2= new Image(pic_width,pic_height);
pic2.src="http://someplace.com/banner2.gif";
pic3= new Image(pic_width,pic_height);
pic3.src="http://someplace.com/banner3.gif";
pic4= new Image(pic_width,pic_height);
pic4.src="http://someplace.com/banner4.gif";
pic5= new Image(pic_width,pic_height);
pic5.src="http://someplace.com/banner5.gif";
}

/* define banner urls */

urlad1="http://someplace1.com";
urlad2="http://someplace2.com";
urlad3="http://someplace3.com";
urlad4="http://someplace4.com";
urlad5="http://someplace5.com";

/* no need to edit past this point (unless you want to add more image
and url slots) */

if (alignment==1)
{
cent_it="<CENTER>";
cent_it2="<\/CENTER>";
}
else
{
cent_it="";
cent_it2="";
}

function get_random(maxNum)
{
if (Math.random && Math.round)
{
var ranNum= Math.round(Math.random()*(maxNum-1));
ranNum+=1;
return ranNum;
}
else
{
today= new Date();
hours= today.getHours();
mins= today.getMinutes();
secn= today.getSeconds();
if (hours==19)
hours=18;
var ranNum= (((hours+1)*(mins+1)*secn)%maxNum)+1;
return ranNum;
}
}

function get_Image()
{
if (document.images)
{
var choose_one= get_random(5);
choose_one--;

var pics= new Array(5)
pics[0]=pic1.src;
pics[1]=pic2.src;
pics[2]=pic3.src;
pics[3]=pic4.src;
pics[4]=pic5.src;

var aurl= new Array(5)
aurl[0]=urlad1;
aurl[1]=urlad2;
aurl[2]=urlad3;
aurl[3]=urlad4;
aurl[4]=urlad5;

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG
SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);
}
}
//-->
</SCRIPT>

in the body section:

<SCRIPT language="JavaScript">
<!--
get_Image()
//-->
</SCRIPT>

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'
target=\"_blank\"><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

Mick

Greg P. wrote:

I've got this script that's supposed randomly pic banner ads to
display. It works fine as shown at the bottom.

The problem is when I try to change the line:
document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG
SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

to

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'
target="_blank"><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

I want to set the target to "_blank", so if the user clicks on the ad
it opens in a new window. But when I do this, it ends up not doing
anything at all! Any suggestions? The complete script is located
below.



(in the head section)

SCRIPT language="JavaScript"
!--
/* You can get this script and many others
by visiting JavaScript City at: http://www.javascriptcity.com . */

pic_width=468; /*change to match the height of all your images */
pic_height=60; /* change to match the width of all your images */
border_size=0; /* change to the border size you want on the images
*/
alignment=1; /* 0=left,1=center */

/* define image urls */

if (document.images)
{
pic1= new Image(pic_width,pic_height);
pic1.src="http://someplace.com/banner1.gif";
pic2= new Image(pic_width,pic_height);
pic2.src="http://someplace.com/banner2.gif";
pic3= new Image(pic_width,pic_height);
pic3.src="http://someplace.com/banner3.gif";
pic4= new Image(pic_width,pic_height);
pic4.src="http://someplace.com/banner4.gif";
pic5= new Image(pic_width,pic_height);
pic5.src="http://someplace.com/banner5.gif";
}

/* define banner urls */

urlad1="http://someplace1.com";
urlad2="http://someplace2.com";
urlad3="http://someplace3.com";
urlad4="http://someplace4.com";
urlad5="http://someplace5.com";

/* no need to edit past this point (unless you want to add more image
and url slots) */

if (alignment==1)
{
cent_it="<CENTER>";
cent_it2="<\/CENTER>";
}
else
{
cent_it="";
cent_it2="";
}

function get_random(maxNum)
{
if (Math.random && Math.round)
{
var ranNum= Math.round(Math.random()*(maxNum-1));
ranNum+=1;
return ranNum;
}
else
{
today= new Date();
hours= today.getHours();
mins= today.getMinutes();
secn= today.getSeconds();
if (hours==19)
hours=18;
var ranNum= (((hours+1)*(mins+1)*secn)%maxNum)+1;
return ranNum;
}
}

function get_Image()
{
if (document.images)
{
var choose_one= get_random(5);
choose_one--;

var pics= new Array(5)
pics[0]=pic1.src;
pics[1]=pic2.src;
pics[2]=pic3.src;
pics[3]=pic4.src;
pics[4]=pic5.src;

var aurl= new Array(5)
aurl[0]=urlad1;
aurl[1]=urlad2;
aurl[2]=urlad3;
aurl[3]=urlad4;
aurl[4]=urlad5;

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'><IMG
SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);
}
}
//--
/SCRIPT

in the body section:

SCRIPT language="JavaScript"
!--
get_Image()
//--
/SCRIPT

On Mon, 19 Jul 2004 14:05:45 -0400, Mick White
<mwhite13 (AT) BOGUSrochester (DOT) rr.com> wrote:

document.write(cent_it+"<A HREF='"+aurl[choose_one]+"'
target=\"_blank\"><IMG SRC='"+pics[choose_one]+"' width='"+pic_width+"'
height='"+pic_height+"' border='"+border_size+"'></A>"+cent_it2);

Thanks! That did it!